Skip to content

Remove unused 'descendantCount' from tagging API#2970

Merged
bradenmacdonald merged 1 commit intoopenedx:masterfrom
open-craft:braden/descendantCount
Apr 2, 2026
Merged

Remove unused 'descendantCount' from tagging API#2970
bradenmacdonald merged 1 commit intoopenedx:masterfrom
open-craft:braden/descendantCount

Conversation

@bradenmacdonald
Copy link
Copy Markdown
Contributor

@bradenmacdonald bradenmacdonald commented Mar 31, 2026

I merged openedx/openedx-core#517 to remove descendantCount from the tagging API. It's expensive to compute and we have no use for it. This PR just updates our fixtures to match.

Private ref: MNG-4914

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Mar 31, 2026
@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented Mar 31, 2026

Thanks for the pull request, @bradenmacdonald!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Mar 31, 2026
@bradenmacdonald
Copy link
Copy Markdown
Contributor Author

bradenmacdonald commented Mar 31, 2026

@ChrisChV could you please review this very simple PR?

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 31, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.56%. Comparing base (0fe8109) to head (9be4335).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #2970    +/-   ##
========================================
  Coverage   95.56%   95.56%            
========================================
  Files        1349     1349            
  Lines       31158    31158            
  Branches     6833     7084   +251     
========================================
  Hits        29776    29776            
+ Misses       1332     1320    -12     
- Partials       50       62    +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Apr 1, 2026
ChrisChV
ChrisChV approved these changes Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍 Fix the conflicts to merge the PR.

  • I tested this: I tested the Taxonomy page and I imported a Taxonomy.
  • I read through the code and considered the security, stability and performance implications of the changes.
  • I tested that the UI can be used with a keyboard only (tab order, keyboard controls).

@bradenmacdonald bradenmacdonald force-pushed the braden/descendantCount branch from 4185fcd to 9be4335 Compare April 2, 2026 00:18
@bradenmacdonald bradenmacdonald enabled auto-merge (squash) April 2, 2026 00:19
@bradenmacdonald
Copy link
Copy Markdown
Contributor Author

bradenmacdonald commented Apr 2, 2026

Thanks @ChrisChV !

@bradenmacdonald bradenmacdonald merged commit ca42550 into openedx:master Apr 2, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Contributions Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisChV ChrisChV ChrisChV approved these changes

Assignees

No one assigned

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bradenmacdonald @openedx-webhooks @ChrisChV @mphilbrick211